Ticket #761 (closed Feature Requests: invalid)

Opened 3 years ago

Last modified 1 year ago

Linux specific: install_amp

Reported by: pneumann@gmail.com Assigned to: diego_iastrubni
Priority: blocker Milestone: 2.3
Component: Installation Version: 2.1
Keywords: Cc:
Confirmation: SVN Revision (if applicable):
Backend Engine: All Backend Engine Version:

Description

Hello.

I did some changes in install_amp, so it would be more package friendly. Making questions to the user when installing makes packaging much more difficult.

I try to make the changes as little intrusive as i could.

with this changes, i can execute

./install_amp --fopwebroot=/usr/local/www/data/FreePBX/panel --webroot=/usr/local/www/data/FreePBX --cgibin=/usr/local/www/cgi-bin --bin=/usr/local/bin --sbin=/usr/local/sbin --asteriskuser=asteriskUsuario --asteriskpass=MiClave? --systemconfig=/usr/local/etc --dbhost=10.0.0.10 --username=asteriskuser --password=amp109

and this would let me with a working FreePBX base to use on FreeBSD

Apart of the patch, there is something would like to discuss: the dependency the installer has, about the mysql database. It needs to be set up before running the script, so it can apply the update scripts. It would be much nicer, to no have this dependency, as normally, the instalation of software comes before the configuration of it. Making the database avaible is something admins do after instaling software. It would be nice if you could provide a simple pair of .sql script so be executed after instalation, just like version 2.0.0, and move this out of install_amp. Maybe providing a config_amp.

I think this would make packaging more easily too.

Hope my text was understandable :-]

Attachments

install.diff (13.9 kB) - added by pneumann@gmail.com on 05/01/06 14:55:53.
install.2.diff (14.2 kB) - added by anonymous on 05/01/06 15:02:01.
Ups (missed something)
install.3.diff (14.2 kB) - added by pneumann@gmail.com on 05/01/06 15:03:09.
Ups (missed something)
freepbx-2.1.tar (164.0 kB) - added by killfill on 05/28/06 16:00:46.
FreePBX 2.1 port

Change History

05/01/06 14:55:53 changed by pneumann@gmail.com

  • attachment install.diff added.

05/01/06 15:02:01 changed by anonymous

  • attachment install.2.diff added.

Ups (missed something)

05/01/06 15:03:09 changed by pneumann@gmail.com

  • attachment install.3.diff added.

Ups (missed something)

05/01/06 15:04:13 changed by pneumann@gmail.com

(sorry about the multiple posts. the last patch is the one that counts.)

05/05/06 10:14:09 changed by RyanCourtnage

  • owner set to RyanCourtnage.
  • status changed from new to assigned.
  • milestone changed from 2.1 to 2.2.

Hi,

Thanks for your patch. We're currently in beta, and don't want to commit such a significant change at this stage. After the 2.1 release, I'll commit your change to SVN.

Regarding the database dependency, would you be willing to take a first crack at a patch? install_amp? is used to perform both installs and updates. Updates _do_ require DB connectivity. Perhaps the script can simply check if it's installing or updating (ie: look for amportal.conf), and eliminate the database connectivity if installing?

Looking forward to freebsd packages!!

05/28/06 06:45:40 changed by wozto1s

  • component changed from - choose - to Installation.

05/28/06 16:00:06 changed by killfill

First, sorry for making so many tickets for this issue :-]

Maybe all tickets wich are titled "linux specific.." should be deleted except this one.

Ok.

I can say, freepbx works pretty well on freebsd

Did a port for freepbx 2.1 wich works fine.

Im attaching the whole freebsd port, wich includes the patched files

But, i think, the instalation procedure is still "package unfriendly", althoght packaging works pretty well now for freebsd.

the directory "files" contains the modified files. (patches), and in the Makefile in the do-install tag, you can see some more stuff.

I did change the DB install procedure, wich is included in 3 files: amportal-db-functions.sh amportal-db-install.sh amportal-db-remove.sh

Thanks to Diego and Tier_1 for the tips!

I hope at least some of this changes (or make better ones) becomes part of FreePBX, so when it upgrades less work would have to be done.

Hope someone can confirm this works ok, before sending the port to the freebsd tracker.

http://www.aussievoip.com/wiki/index.php?page=freePBX-FreeBSD

thanks for the greate software!

05/28/06 16:00:46 changed by killfill

  • attachment freepbx-2.1.tar added.

FreePBX 2.1 port

05/29/06 12:01:39 changed by ewildgoose

I have had a couple of aborted attempts to build a gentoo package for AMP (gentoo is very similar to the FreeBSD ports system) and so this is a really interesting change. I will be watching closely post v2.1 to see if we can't use this to get an ebuild out for Gentoo

http://bugs.gentoo.org/show_bug.cgi?id=99860

Please see this as another request to see this change committed and the DB stuff broken out seperately!

06/25/06 18:12:26 changed by RobThomas

  • owner changed from RyanCourtnage to RobThomas.
  • status changed from assigned to new.

OK, I _really_ was going to apply this, but I don't like the way it makes assumptions. I'd much rather prompt the users with a default _unless_ they specify something on the command line. If you've got the time, I'd really appreciate it if you could re-implement it that way and it'll definately get into 2.2 then.

If you have a look at trunk, I've partly implemented the changes you want in r2092 (r2093 if you're clicking on it in trac), but left most of them commented out. I s'pose my main issue is that you're using global variables with it - I would think the better idea would be to use $ampconfVAR? and then only prompt if it's not defined. I guess. 8). What do you think?

--Rob

07/04/06 19:27:00 changed by _xo_

The FreeBSD port is broken because of the way of install_amp script checks the Asterisk version.

Why checking if a module exists (even if it exists only in 1.2) when we can use 'asterisk -V' to grab the Asterisk version ?

07/24/06 14:48:36 changed by RobThomas

  • milestone changed from 2.2 to 2.3.

Moving this to 2.3. We don't assume that asterisk is running, and func_callerid is a 1.2-ism. Also, if freebsd isn't putting the asterisk modules in astmoddir then there's something serously wrong with the way freebsd is doing stuff! Where _is_ it putting the modules (and why isn't it changing astmoddir to suit?)

09/15/06 19:28:45 changed by RobThomas

  • type changed from Bugs to Feature Requests.

10/22/06 13:11:48 changed by diego_iastrubni

what else is needed to close this bug...? can we do this for 2.2...?

01/08/07 11:46:49 changed by

  • milestone deleted.

Milestone 2.3 deleted

01/08/07 12:06:04 changed by vgster

  • milestone set to 2.3.

04/17/07 22:55:41 changed by diego_iastrubni

  • owner changed from RobThomas to diego_iastrubni.
  • engine_version changed.
  • svn_rev changed.

started dealing with this in changeset:3926

04/25/07 01:18:09 changed by diego_iastrubni

  • status changed from new to assigned.

05/05/07 21:33:47 changed by diego_iastrubni

Is this safe to remove? Any standing issues in this ticket? Safe to close by now?

07/26/07 08:23:26 changed by p_lindheimer

  • status changed from assigned to closed.
  • resolution set to invalid.

this is too old - too much has changed, closing.