Call Me feature for ARI (click-to-call voicemail playback)

Icon for Download link.

Icon for computer Playback.

Icon for telephone Playback.

copied everything over and got this error:

[root@asterisk1 html]# patch -p0 < callme.patch patch: **** Only garbage was found in the patch input.

Replying to totalimpact:

copied everything over and got this error: [root@asterisk1 html]# patch -p0 < callme.patch patch: **** Only garbage was found in the patch input.

ME Too!!

Bill/W5WAF

Recently tried patching on PiaF 1.2 and some hunks failed.

root@voip2:/var/www/html $ patch -p0 < callme.patch patching file recordings/includes/callme.php patching file recordings/includes/common.php Hunk #1 succeeded at 428 (offset -8 lines). patching file recordings/misc/callme_page.php patching file recordings/misc/play_page.php patching file recordings/modules/settings.module patching file recordings/modules/voicemail.module Hunk #3 succeeded at 378 with fuzz 1 (offset -5 lines). Hunk #4 FAILED at 399. Hunk #5 FAILED at 424. Hunk #6 succeeded at 464 (offset -9 lines). Hunk #7 succeeded at 486 (offset -5 lines). Hunk #8 succeeded at 504 (offset -9 lines). Hunk #9 succeeded at 563 (offset -5 lines). 2 out of 9 hunks FAILED -- saving rejects to file recordings/modules/voicemail.module.rej

You should probably tell us what version of ARI your patch file is for, because my voicemail.module doesn't jibe with your patch file. It has a few differences in the code that will probably cause problems. I am patching ARI that comes with FreePBX version 2.4.1.0. I managed to manually patch the voicemail.module to avoid the errors in the previous post, but it won't work.

totalimpact, w5waf, and warmbowski,

Thanks for your interest in this patch. As the ticket says, this feature is for Version: 2.5-branch. The patch file is specifically for 2.5rc1.1, as noted in the comments for the patch file. This patch file should not be installed on a FreePBX 2.4 or earlier system.

If you are trying to install this patch on 2.5rc1.1 and receive a message that only garbage was found in the patch input, please open the patch file in a text editor and compare the file contents with what is displayed in the Trac when you click on the callme.patch link above. Please post back any additional troubleshooting information.

Thanks, Seth

I've just tested on a 2.5rc1 system. Patch apply correctly, but:

- it's not compatible with php 4 (gives this error:

httpd: PHP Parse error:  parse error, unexpected T_STRING, expecting T_OLD_FUNCTION or T_FUNCTION or T_VAR or '}' in /opt/freepbx/recordings/modules/voicemail.module on line 12

)

- with php 5.1.6, I can log into the ARI, but playback and download links are not shown, see the screenshot

Links not shown

php 4 does not support 'private' - try getting rid of that. I didn't review the code but I think that will be sufficient to fix it. (and if I'm saying something bad I'm sure sasargen will jump in and correct me.

Sorry, you can forget the problem about missing links (it' was just a problem with the 3 png). Links are displayed now. I havn't tested a lot for now, but downloads do not work, I've got

404 File not found!

dani,

Thanks for testing this patch. The error:

404 File not found!

is from the audio.php file and indicates that it has a bad path to the recording file or that the file extension does not match mp3, wav, Wav, WAV, or gsm. Please edit your copy of recordings/misc/audio.php and change the two occurences of:

die("<b>404 File not found!</b>")

to:

die("<b>404 File not found!</b><br>$path")

This should display the full unencrypted path of the recording file on the line after the 404 message. If the errors continue, please post the new error message with the path.

Also, did philippel's suggestion to remove 'private' from line 12 of voicemail.module allow this patch to run on php 4?

Thanks, Seth

Replying to p_lindheimer:

Thanks for that catch. Just removing the 'private' will still result in the same error. Instead, replace 'private' with 'var'. This is the way to declare class variables in PHP4. This also works in PHP5, since PHP5 recognizes 'var' as a synonym for 'public' when declaring class members.

Further details at http://us2.php.net/manual/en/language.oop5.visibility.php

Hi. It seems to be a problem while the path is decrypted. $path content looks like this:

!-°khz“ºñ¼8¢á]ÈÃ1e
þwÕFa<öÎeuñÓš§bЂbìßDQÆîÄÎ>jéìYÚtýør9ÆÉxs·5’

For the php4 compatibility, I'll test this as soon as I re-install my test server as I've upgraded it to php5.

Ok, the problem comes from urlencode:

If I replace this line (audio.php, line 19):

$path = $crypt->decrypt(urlencode($_GET['recording']),$ARI_CRYPT_PASSWORD);

by this:

$path = $crypt->decrypt($_GET['recording'],$ARI_CRYPT_PASSWORD);

I can download the file

sasargen, that is correct and it represents a general bug in ARI. (It may be what you had introduced or maybe it was not there). In crypt.php, this is wrong:

     $enc = base64_decode(urldecode($enc));                                                                                                                  

It is already decoded by the browser. I think the solution is to do what we did for system recordings. Remove the urlencode and urldecode from the crypt methods, and put the responsibility on the calling party to do the urlencode after it is encrypted. This keeps the call symmetrical. Do you want to change that in the main ARI base? (And then we can merge that change and other changes since the branch to your branch.

Additional work on this feature can be found in the ari_changes branch of the SVN. See:

http://freepbx.org/trac/browser/freepbx/branches/ari_changes/amp_conf/htdocs/recordings

Patch to add Callme Feature to FreePBX ARI Framework 2.5.1.1

Full copies of files updated by the patch file

Custom dialplan code for handling click-to-call voicemail playback.

(In [7014]) re #3042 removed vm-starmain since that is not an option

In [7130] added in code to make vm-starmain option work. Marked ticket as fixed, since this patch has merged into FreePBX 2.5 as part of fw_ari-2.5.2.rc1.