Open Source Training Seminar FreePBX Paid Support

Ticket #3021 (closed Bugs: wontfix)

Opened 2 months ago

Last modified 2 months ago

Ring Group CID Prefix trims trailing space

Reported by: Nick_Lewis Assigned to: p_lindheimer
Priority: minor Milestone: 2.5
Component: Ring Groups Version: 2.2.1
Keywords: Cc:
Confirmation: Confirmed SVN Revision (if applicable):
Backend Engine: All Backend Engine Version:

Description

If you specify a trailing space on a Ring Group CID Prefix it is removed e.g a anonymous call to a ringgroup with the prefix entered as "Sales " results in a display of "Salesanonymous" rather than "Sales anonymous".

Attachments

func.ringgroups.patch (1.5 kB) - added by Nick_Lewis on 08/05/08 08:45:04.
ok ok here is a proper patch against head

Change History

08/05/08 07:50:42 changed by Nick_Lewis

This problem appears to be caused by a bug in mysql itself. A workaround is as follows:

(i) in function ringgroups_add

+ $grppre .= "*";

$sql = "INSERT etc

(ii) in function ringgroups_get

$results = sql("SELECT etc

+ $resultsgrppre? = substr($resultsgrppre?,0,-1);

08/05/08 08:00:12 changed by Nick_Lewis

$results<opensquarebracket>'grppre']

08/05/08 08:45:04 changed by Nick_Lewis

  • attachment func.ringgroups.patch added.

ok ok here is a proper patch against head

08/05/08 08:50:43 changed by Nick_Lewis

patch attached

08/08/08 15:23:00 changed by p_lindheimer

  • milestone changed from Cut Line to 2.5.

08/10/08 13:28:50 changed by p_lindheimer

  • status changed from new to closed.
  • confirmation changed from Unreviewed to Confirmed.
  • resolution set to wontfix.

This is a result of MySQL versions prior to version 5 I believe, the trailing spaces of a varchar are stripped. Trying this on version 5 MySQL does not strip the trailing space. I believe this could be fixed by changing the type from varchar to text. However, this is going to be an issue for all other modules that allow a cid prefix as they are all using varchar.

Since this is addressed in a later version of MySQL, and since putting a space can be very subtle anyhow, I'm closing this as wontfix. You can upgrade to MySQL 5 if important, or simply use another separator character like a ":" which is also visible from when input into the text box.

Donate



Support
Download
Develop
Forums
News
Documentation
Paid Support
About

Paid Ads