Open Source Training Seminar FreePBX Paid Support

Ticket #2962 (closed Feature Requests: fixed)

Opened 1 month ago

Last modified 1 month ago

add waring if if answerstatus is invalid

Reported by: lazytt Assigned to: p_lindheimer
Priority: minor Milestone: 2.5
Component: Core - Trunks/Routing Version: 2.4-branch
Keywords: Cc:
Confirmation: Need Feedback SVN Revision (if applicable):
Backend Engine: All Backend Engine Version:

Description

Will provide better feedback in case of a problem with the dialed number (like pri code: 23, 160, etc)

exten => s-BUSY,1,Noop(Dial failed due to trunk reporting BUSY - giving up)
exten => s-BUSY,n,Playtones(busy)
exten => s-BUSY,n,Busy(20)
exten => s-NOANSWER,1,Noop(Dial failed due to trunk reporting NOANSWER - giving up)
exten => s-NOANSWER,n,Playtones(congestion)
exten => s-NOANSWER,n,Congestion(20)
exten => s-CANCEL,1,Noop(Dial failed due to trunk reporting CANCEL - giving up)
exten => s-CANCEL,n,Playtones(congestion)
exten => s-CANCEL,n,Congestion(20)

add this:

exten => s-CHANUNAVAIL,1,Noop(Dial failed due to trunk reporting CHANUNAVAIL - giving up)
exten => s-CHANUNAVAIL,n,Playback(ss-noservice)
exten => s-CHANUNAVAIL,n,Congestion(20)
exten => _s-.,1,GotoIf($["x${OUTFAIL_${ARG1}}" = "x"]?noreport)
exten => _s-.,n,AGI(${OUTFAIL_${ARG1}})
exten => _s-.,n(noreport),Noop(TRUNK Dial failed due to ${DIALSTATUS} - failing through to other trunks)
exten => disabletrunk,1,Noop(TRUNK: ${OUT_${DIAL_TRUNK}} DISABLED - falling through to next trunk)
exten => bypass,1,Noop(TRUNK: ${OUT_${DIAL_TRUNK}} BYPASSING because dialout-trunk-predial-hook)
exten => h,1,Macro(hangupcall,)

Attachments

outbound.diff (1.9 kB) - added by lazytt on 07/28/08 03:03:02.

Change History

07/28/08 02:50:23 changed by lazytt

  • confirmation changed from Unreviewed to Need Feedback.
  • milestone changed from Cut Line to 2.5.

also, why do we need tones to play for 20 seconds? Nobody listen that long...

07/28/08 02:53:22 changed by lazytt

The patch also allows for the precise error codes (the reason for hangup) to be played, see here for more: http://www.voip-info.org/tiki-index.php?page=Asterisk+variable+hangupcause

Hangupcause is the latest PRI hangup return code on a zap channel connected to a PRI interface. 
Note that this also works on SIP channels, maybe other channels as well.

07/28/08 03:03:02 changed by lazytt

  • attachment outbound.diff added.

07/29/08 19:16:05 changed by p_lindheimer

  • component changed from - choose - to Core - Trunks/Routing.

07/29/08 19:38:29 changed by p_lindheimer

  • type changed from Bugs to Feature Requests.

07/30/08 21:06:34 changed by p_lindheimer

Leave the busy, congestion, etc. at 20 seconds please.

As far as the HANGUPCAUSE, I think the Noop is a good idea. There is no harm done if the trunk is a type that does not report anything and is helpful in the logs if it does. But I would not put any of the playback bit, especially since you may have failover trunks that it is going to try next which will get tried in the case of an unavailable channel. So why don't you modify the patch for just that and we'll re-review.

07/31/08 14:34:47 changed by p_lindheimer

  • status changed from new to closed.
  • resolution set to fixed.

(In [6238]) closes #2962 report hangupcause on trunks that report CHANUNAVAIL

Donate



Support
Download
Develop
Forums
News
Documentation
Paid Support
About

Paid Ads