Ticket #2945 (closed Bugs: fixed)

Opened 6 months ago

Last modified 6 months ago

VM_PREFIX incorrectly assumed always to be * when generating FOP configuration

Reported by: Nick_Lewis Assigned to: asternic
Priority: minor Milestone: 2.5
Component: Flash Operator Panel Version: SVN-HEAD
Keywords: Cc:
Confirmation: Need testing SVN Revision (if applicable):
Backend Engine: All Backend Engine Version:

Description

retrieve_op_conf_from_mysql.pl assumes that the way to dial direct to the voicemail of a user is to prefix his number with a star. However the VM_PREFIX is a configurable parameter in the general settings webpage. Therefore retrieve_op_conf_from_mysql.pl should take this parameter from the global table of the freepbx database.

I suspect that without a fix to this bug it would not be possible on the flash operator panel to drag a call to voicemail if the VM_PREFIX has been changed from the default * setting.

Attachments

retrieve_op_conf_from_mysql.patch (2.4 kB) - added by Nick_Lewis on 07/24/08 09:58:27.
database table name is globals not global

Change History

07/24/08 02:19:28 changed by Nick_Lewis

Nicolas

Sorry I see that this ticket has been automatically assigned to you. (I understand that retrieve_op_conf_from_mysql.pl is the script in freepbx that generates op_buttons*.cfg rather than part of FOP itself). Please reassign it as necessary.

Nick

07/24/08 03:47:19 changed by Nick_Lewis

I have attached a patch (to head post r6146) that I think should deal with the VM_PREFIX. The patch also gets the real dial context rather than assuming "from-internal".

(A minor bug was introduced in r6146 - when the mailbox data in the tech table does not a vmcontext the vmcontext is set to "" rather than left at "default". This patch corrects it)

The patch has yet to be tested.

07/24/08 06:27:08 changed by p_lindheimer

  • confirmation changed from Unreviewed to Need testing.
  • milestone changed from Cut Line to 2.5.

Nick, the patch and fixes are greatly appreciated and sound right. However, they need to be tested before considered. Can you test it and verify that it works properly and then update the ticket? Then we can put it in as it all sounds right.

07/24/08 09:58:27 changed by Nick_Lewis

  • attachment retrieve_op_conf_from_mysql.patch added.

database table name is globals not global

07/24/08 10:08:17 changed by Nick_Lewis

Tested, corrected, and retested patch. FOP now seems to work ok with VM_PREFIX values other than * . I have no more time for further retrieve_op_conf_from_mysql.pl enhancements.

07/25/08 10:05:17 changed by p_lindheimer

  • status changed from new to closed.
  • resolution set to fixed.

(In [6180]) closes #2945 and #2699 proper VM_PREFIX and dynamic screen space allocation, ref #2686 modified