graph pie error

wrong pie

Ok, I find the error(s) I will post them here, hoping somebody could merge these fix in a new release.

3 lines to modify in file /admin/cdr/graph_pie.php

1) The year is badly displayed if crossing year (current_myyear used instead of current_myyear2) 2) (trivial) the slice to explode is the 0 and not the 1 3) The legend are completly wrong becouse need to be reversed

this is the diff file:

diff ../modules/framework/htdocs/admin/cdr/graph_pie.php graph_pie.php

191c191 < $mylegend[] = $months[$current_mymonth2-1]." $current_myyear : ".intval($list_total[0][0]/60)." min"; ---

$mylegend[] = $months[$current_mymonth2-1]." $current_myyear2 : ".intval($list_total[0][0]/60)." min";

210c210 < $p1->ExplodeSlice?(1); ---

$p1->ExplodeSlice?(0);

215c215 < $p1->SetLegends?($mylegend); ---

$p1->SetLegends?(array_reverse ($mylegend));

I will post diff again using WikiFormatting:

diff ../modules/framework/htdocs/admin/cdr/graph_pie.php graph_pie.php

191c191
<       $mylegend[] = $months[$current_mymonth2-1]." $current_myyear : ".intval($list_total[0][0]/60)." min";
---
>       $mylegend[] = $months[$current_mymonth2-1]." $current_myyear2 : ".intval($list_total[0][0]/60)." min";
210c210
< $p1->ExplodeSlice(1);
---
> $p1->ExplodeSlice(0);
215c215
< $p1->SetLegends($mylegend);
---
> $p1->SetLegends(array_reverse ($mylegend));

lanzaandrea, any chance you can resubmit this using "diff -ubB orignal_file modfied_file" format to make sure it will apply. That would be appreciated, then we can have a look.

lanzaandrea, Your patch applied, here is the equivalent:

Index: graph_pie.php
===================================================================
--- graph_pie.php       (revision 5763)
+++ graph_pie.php       (working copy)
@@ -188,7 +188,7 @@
 
        $list_total = $instance_table_graph -> Get_list ($FG_TABLE_CLAUSE, null, null, null, null, null, null);
        $data[] = $list_total[0][0];
-       $mylegend[] = $months[$current_mymonth2-1]." $current_myyear : ".intval($list_total[0][0]/60)." min";
+      $mylegend[] = $months[$current_mymonth2-1]." $current_myyear2 : ".intval($list_total[0][0]/60)." min";
 
 }
 //print_r($data);
@@ -207,12 +207,12 @@
 $graph->title->SetFont(FF_FONT1,FS_BOLD);
 
 $p1 = new PiePlot3D($data);
-$p1->ExplodeSlice(1);
+$p1->ExplodeSlice(0);
 $p1->SetCenter(0.35);
 //print_r($gDateLocale->GetShortMonth());
 //Array ( [0] => Jan [1] => Feb [2] => Mar [3] => Apr [4] => May [5] => Jun [6] => Jul [7] => Aug [8] => Sep [9] => Oct [10] => Nov [11] => Dec )
 //$p1->SetLegends($gDateLocale->GetShortMonth());
-$p1->SetLegends($mylegend);
+$p1->SetLegends(array_reverse ($mylegend));
 
 
 // Format the legend box

However, I'm not sure I'm seeing the issue or I am seeing this patch make my pie chart look wrong. The graph I chose was:

• Monthly Traffic
• Laps of month to compare: 6 months

When I do that, your patch seems incorrect on my display and the current code looks correct. Can some other people take a look at this and give some feedback, maybe I'm missing something or getting confused.

Can anyone else have a look at this. As mentioned, my data looks correct and wrong with the patch, we need another set of eyes or two to tell us what the right answer is so we can close this bug either with our without the supplied patch.

with the fix in r6272 this looks like it has also been addressed. Please review and if not, please provide some specific data to help track it down. Ref #2635

(In [6273]) prepare to publish to address re #2635, re #2792 and error introduced re #2963