Allow * in voicemail password

The attached patch will allow to support star digit in the voicemail password in both the voicemail module and ARI

The current patch seems to have problem with voicemail that are not in the default context and where the password contains a star. Working on fixing this.

any update on this?

I just updates the new patch that takes care of this.

Replying to VoipForces:

I just updates the new patch that takes care of this.

Shouldn't the lines that look like this:

if (preg_match("/^\s*(\d+)\s*=>\s*(.*),(.*),(.*),(.*),(.*)\s*([;#].*)?/",$line,$matches)) { 

be a little more specific, can you try ([\d*]*) or what ever the proper regex syntax would be to allow digits and * only, and not just anything. (sorry my regex is always rusty so not sure if that is correct):

if (preg_match("/^\s*(\d+)\s*=>\s*([\d*]*),(.*),(.*),(.*),(.*)\s*([;#].*)?/",$line,$matches)) { 

and then update the patch and we can have a look. Thanks!

I'm very good at regex either... I'll try the ([\d*]*) and see what it does.

Replying to VoipForces:

I just updates the new patch that takes care of this.

Sorry just noticed also, the removal of this:

"frm_${display}_isVoiceMailEnabled() && !isInteger()", $msgInvalidVmPwd, false)); 

that should not be removed, it will need a different check then !isInteger() (and maybe $msgInvalidVmPwd) but that needs to be addressed or it will allow bogus passwords to be input. Thanks again in advance.

VoiPForces:

any update here, if we can get a proper validation in the vm module and the other changes confirmed or updated then we can put them into the release for some testing.

VoipFOrces - ping, were you going to take care of the last tidbits here so we can put your fix in?

I am planing this for this morning provided I do not get a gizilion calls.

I created a new validation javascript function:

function isValidPwd(s){var i;if(isEmpty(s)) if(isAlphanumeric.arguments.length==1)return defaultEmptyOK;else return(isAlphanumeric.arguments[1]==true);for(i=0;i<s.length;i++){var c=s.charAt(i);if(!(isDigitStar(c))) return false;} return true;}

and

function isDigitStar(c)

{return((c>="0")&&(c<="9")(c=="*"))}

But even if I put letters in the password field they are accepted... Any hints ?

My firefox javascript error console tells me that isValidPwd is not defined, however it is in common/libfreepbx.javascripts.js

Forget it is was a browser cache issue...

New patch against 2.4.1 code

Ok, just uploaded the new patch against the 2.4.1 release

Please reattach in diff format so that trac can recognize the file. diff -uUb > path.diff (i think)

The attached patch was done with

diff-ru

Which is the same method I used the last time. But it is against 2.4.1 and this ticket is tagged to 2.3.1, maybe trac is not able to sync because of that ?

trac doesn't actually compere the diff based on the svn - it comperes it based on the patch file itself... This usually works (I posted it wrong last time):

diff -ubB original_file modified_file > file.diff

Ok, so since 3 files are modified for this patch I have to submit 3 patches ?

If you do a svn diff then you can output it all in one file (and if you going to pull from svn you may want to take a peek at 2.5 ...)

VoipForces?,

thanks for the update however there is an issue. libfreepbx.javascripts.js is an auto-generated file meaning you can't change that. (Not really true, the truth is you need to change the source javascript file where it came from.) You can simply remove the libfreepbx.javascript.js file from your commons diretory and FreePBX will use the unpacked versions where you can make the suggested changes. We'll pack them back up when we package the changes. I believe the file you need to change is in: script.legacy.js.

Next - you mentioned that ARI will not accept the password if changed to * but I don't see any patch to fix the ARI to allow this? Am I missing something?

As far as the patch file. It looks like what you are generating is fine but for some reason trac doesn't like it which is a bit of an inconvenience because we can't just review the patch in trac, so if there is anything you can do to make it viewable in trac it would be appreciated.

thanks again.

VoipForces?,

ping - were you going to do the last tidbits mentioned above plus the require fix for ARI? Otherwise I'll probably move this out of the release as the changes touch quite a few files. Thanks in advance.