Open Source Training Seminar FreePBX Paid Support

Ticket #2772 (closed Bugs: fixed)

Opened 6 months ago

Last modified 3 months ago

retrieve_conf depends on mysql

Reported by: tzafrir Assigned to: ethans
Priority: minor Milestone: 2.5
Component: Sqlite3 Version: 2.4-branch
Keywords: Cc:
Confirmation: Need Feedback SVN Revision (if applicable):
Backend Engine: All Backend Engine Version:

Description

retrieve_conf uses mysql_real_escape_string() in report_errors(), which requires mysql support in PHP.

Attachments

resolve_conf-report_errors-db (1.0 kB) - added by tzafrir on 04/06/08 07:46:58.
patch from Debian package

Change History

04/06/08 07:31:58 changed by tzafrir

sqlite3 has sqlite_escape_string, and pgsql has pgsql_escape_string . I can add a trivial patch for that. But isn't the proper place for escaping in freepbx_log()?

04/06/08 07:46:58 changed by tzafrir

  • attachment resolve_conf-report_errors-db added.

patch from Debian package

04/06/08 07:47:56 changed by tzafrir

Attached a trivial patch I used for my 2.3.1 package. The code seems to be the same in 2.4, though.

04/06/08 08:09:12 changed by tzafrir

freepbx_log() is called for:

freepbx_log('retrieve-conf', 'devel-debug', $dest.' already points to '.$src.' - OK');

Both $src and $dest are the results of addslash() . Is there any actual use in that excessive escaping?

07/01/08 14:36:06 changed by lazytt

  • confirmation changed from Unreviewed to Need Feedback.

Has anyone actualy tested this?

07/01/08 15:27:01 changed by p_lindheimer

  • milestone changed from Cut Line to 3.0.

will defer this until work goes in for the sqlite support and then this should be addressed at the time.

07/02/08 03:38:13 changed by tzafrir

Yes, I have tested it, and I use it in my packages.

It is simple, clear, and simple to reproduce.

07/24/08 17:47:59 changed by lazytt

  • owner changed from diego_iastrubni to ethans.

07/25/08 18:55:10 changed by p_lindheimer

  • status changed from new to closed.
  • resolution set to fixed.

(In [6189]) fixes #2772 use appropriate escape_string function for the given db being used

Donate



Support
Download
Develop
Forums
News
Documentation
Paid Support
About

Paid Ads