Open Source Training Seminar FreePBX Paid Support

Ticket #2750 (closed Bugs: fixed)

Opened 7 months ago

Last modified 1 month ago

Decision between Pickup() and DPickup() in app-pickup is not working.

Reported by: alien Assigned to:
Priority: minor Milestone: 2.5
Component: Feature Code Admin Version: 2.4.0
Keywords: Pickup() Cc:
Confirmation: Unreviewed SVN Revision (if applicable):
Backend Engine: All Backend Engine Version:

Description

In /admin/modules/core/functions.inc.php:

// Call pickup using app_pickup - Note that '**xtn' is hard-coded into the GXPs and SNOMs as a number to dial // when a user pushes a flashing BLF. if ($fc_pickup != ) {

$ext->addInclude('from-internal-additional', 'app-pickup'); $fclen = strlen($fc_pickup); $ext->add('app-pickup', "_$fc_pickup.", , new ext_NoOp('Attempt to Pickup ${EXTEN:'.$fclen.'} by ${CALLERID(num)}')); if (strstr($version, 'BRI'))

$ext->add('app-pickup', "_$fc_pickup.", , new ext_dpickup('${EXTEN:'.$fclen.'}'));

else

$ext->add('app-pickup', "_$fc_pickup.", , new ext_pickup('${EXTEN:'.$fclen.'}'));

}

This will never trigger. $version is only version number without anything else. For example my asterisk -V:

Asterisk 1.4.17-BRIstuffed-0.4.0-test6

$version returns only "1.4.17".

Change History

07/25/08 19:36:05 changed by p_lindheimer

  • milestone changed from Cut Line to 3.0.

if you can provide a suggestion to detect this we can put it in.

08/29/08 15:16:06 changed by p_lindheimer

(In [6506]) return the raw Asterisk version info obtained from checking the version info re #2750 and re #3128

08/29/08 15:19:38 changed by p_lindheimer

  • milestone changed from 3.0 to 2.5.

08/29/08 15:20:47 changed by p_lindheimer

  • status changed from new to closed.
  • resolution set to fixed.

(In [6507]) closes #2750 and re #3128 requires r6506 to be included in next framework

09/02/08 16:41:55 changed by p_lindheimer

(In [6539]) Merged revisions 6492-6538 via svnmerge from http://svn.freepbx.org/freepbx/branches/2.5

........

r6504 | p_lindheimer | 2008-08-29 11:13:55 -0700 (Fri, 29 Aug 2008) | 1 line

don't define WEBROOT if AMPWEBADDRESS is not defined, it breaks the graphing libraries (which seem to otherwise function fine without it defined)

........

r6505 | p_lindheimer | 2008-08-29 14:55:13 -0700 (Fri, 29 Aug 2008) | 1 line

make max files for call monitor configurable within main.conf.php, default remains the same

........

r6506 | p_lindheimer | 2008-08-29 15:16:05 -0700 (Fri, 29 Aug 2008) | 1 line

return the raw Asterisk version info obtained from checking the version info re #2750 and re #3128

........

r6513 | p_lindheimer | 2008-08-30 20:53:16 -0700 (Sat, 30 Aug 2008) | 1 line

re #3124 put url in auto-generated warnings to reference further help, still need to update all the fixed files with similar warnings but they should consider including some custom instructions such as sip.conf can suggest what sort of sip settings go in which includes files, etc.

........

r6515 | p_lindheimer | 2008-08-31 07:35:02 -0700 (Sun, 31 Aug 2008) | 1 line

re #3134 makes ajax refresh rates for dashboard configurable

........

r6519 | p_lindheimer | 2008-08-31 15:40:00 -0700 (Sun, 31 Aug 2008) | 1 line

re #3131 add Mixmonitor and Stopmonitor to extension class

........

r6525 | p_lindheimer | 2008-08-31 16:36:33 -0700 (Sun, 31 Aug 2008) | 49 lines

closes #3137

db_connect.php:

  • removed all checks for notification panel when in quietmode since it's usually used for ajax calls and other light weight calls that can do without the overhead.

config.php:

  • added restrictmods parameter, populated with '/' separted module names. If passed, only these modules will have their functions.inc.php files included. Used for light weight ajax and similar calls, to avoid the overhead if we know we don't need those.

  • removed all checks for notification panel when in quietmode. Removed the inclusion of hooks when in quietmode.

functions.inc.php:

  • added modulelist class, used to cache the module xml structure which is now serialized and saved to the db to avoid the heavy xml processing overhead of reading all the module.xml files. (should probably move most of module_getinfo() into the class but for starters just did minimal changes to avoid introducing bugs since this is pretty sensitive).
  • fixed several instances of using " instead of ' in sql satements which breaks sqlite3 queries often.
  • replaced all instances of addslashes() with $db->escapeSimple() since sqlite3 is not compatible with addslashes() and this makes it db independent through pear.
  • added third argument to module_getinfo() defaulting in false. Setting to true forces a read of all the module.xml files. Module Admin and module_admin should always set this to true.

header.php

  • removed all checks for notification panel when in quietmode

page.modules.php

  • added third true paramter to module_getinfo

........

r6526 | p_lindheimer | 2008-08-31 17:16:27 -0700 (Sun, 31 Aug 2008) | 49 lines

closes #3137

module_admin

  • added third true paramter to module_getinfo

........

Donate



Support
Download
Develop
Forums
News
Documentation
Paid Support
About

Paid Ads