Order by Flags causing incorrect ordering in conf files

Actually I think it may be order by keyword DESC that is causing the problem rather than Order By Flags however the issue remains regardless of the code that is the cause

A further issue identified is that this prevents specifying the preferred codec order

robmac, can you try to dig through and be more specific on the issue? In the past it would always order DESC which did break somethings. At least for trunks, I modified things in 2.4 and hijacked the flags field to create a sequence so that the order would remain as you put it in:

  foreach($confitem as $k=>$v) {
    $seq = ($disable_flag == 1) ? 1 : $seq+1;
    $dbconfitem[]=array($k,$v,$seq);
  }
  $compiled = $db->prepare("INSERT INTO $table (id, keyword, data, flags) values ('9999$trunknum',?,?,?)");
  $result = $db->executeMultiple($compiled,$dbconfitem);

Is the issue with extensions and manifested uniquely with the codecs since it is treated a little differently with the codec=ulaw&gsm&g729 format in one text box?

Hi Philippe,

Trunk settings are written to file in the order entered, but extensions are sorted in reverse alpha order.

Removing "order by keyword DESC" causes the entries to be written in ascending order so "order by keyword DESC" is not the cause and it doesn't matter whether the entries are in ascending or descdening order as in both cases it is wrong !

For IAX & SIP I believe that the only thing currently affected is codecs although this could easily change with the addition of new values in 1.6 or the addition of any of the existing values to the subset currently being specified.

For H323, MGCP & Skinny it is reaking havoc with numerous settings, the order that the entries are in the code (and the gui) need to be preserved.

My PHP is not yet good enough to deal with this so I am hoping one of the official developers can address this.

Thanks Rob

Rob, it does not surprise me that the Device settings have an issue. The trunks were only fixed in 2.4. Everything used to be ordered DESC. This was a hack someone did a long time ago so that 'disallow=all' , 'allow=codecs' would work. It broke deny/permit in iax, #2062, which the new sequencing fixed.

I'll leave the ticket open. I suspect it will not be hard to modify the device code to simply apply the sequence numbering to the flags as they are listed. It just needs to be assured that the options are presented in the proper order. The 'safest' change would be to hard code the sequence on existing sip and iax technologies for these fields to DESC order so that they will continue to be generated as they have been and not cause other anomalies, but allow new ordering to be applied.

In the case of your new code, there is nothing stopping you from applying sequence numbers to the flags to assure that your stuff gets generated in the proper order.

closing this bug. All of the generation sorts on the flags, then DESC and prior to the flag being used, it always sorted on DESC. If there is an issue with the order, then a bugs should be filed against the code that is storing any particular device information since the order it is output can be controlled through the 'flag' seq number as with trunks.