"stop gracefully" deprecated in Asterisk 1.6

I understand how it is supposed to work. This is what is showing in the table:

No such command 'show uptime' (type 'help' for help)

OOPS: Commented wrong ticket

stop gracefully works in 1.6. It's labeled as deprecated, so we should sort it out. But the patch does this to 1.2:

ast12fbx24:~# amportal stop



STOPPING ASTERISK
No such command 'core' (type 'help' for help)
Verbosity is at least 3

Disconnected from Asterisk server
Asterisk Stopped

STOPPING FOP SERVER

So lets make thoose errors go away.

Philippe - is the error really such a big deal? or is there a simple way to check the asterisk version?

How about:

Index: freepbx_engine
===================================================================
--- freepbx_engine      (revision 5835)
+++ freepbx_engine      (working copy)
@@ -135,7 +135,8 @@
 pid_length=`pidof asterisk|awk '{print length($0)}'`
        if [ "$pid_length" != "0" -a "$pid_length" != "" ]
                then
-                       /usr/sbin/asterisk -rx "stop gracefully"
+                       /usr/sbin/asterisk -rx "core stop gracefully" | grep -v "No such command"
+                       /usr/sbin/asterisk -rx "stop gracefully" | grep -v -E "No such command|deprecated"
                        echo "Asterisk Stopped"
                fi
 }

The first will get rid of errors coming form 1.2, the second will get rid of the deprecated message coming from 1.4 and the error that I suspect will come for 1.6 since I'm assuming the old syntax is gone?

That would be my suggestion, if someone wants to try it out and say if it works we can go for it

Now ... didn't I recall another ticket about stop gracefully going away or am I just imagining that?

The 'proper' way to handle this (besides checking for the asterisk version - which is an unnecessary pain when such a simple solution is avalible) would probably be as follows:

Index: amp_conf/bin/freepbx_engine
===================================================================
--- amp_conf/bin/freepbx_engine (revision 5877)
+++ amp_conf/bin/freepbx_engine (working copy)
@@ -135,7 +135,8 @@
 pid_length=`pidof asterisk|awk '{print length($0)}'`
        if [ "$pid_length" != "0" -a "$pid_length" != "" ]
                then
-                       /usr/sbin/asterisk -rx "stop gracefully"
+                       /usr/sbin/asterisk -rx "stop gracefully" > /dev/null
+                       /usr/sbin/asterisk -rx "core stop gracefully" > /dev/null
                        echo "Asterisk Stopped"
                fi
 }

pnlarsson - can you test my patch on 1.6? It should be fine but I don't have 1.6 loaded to try. (or drmessano if you could try it since you reported it if you have a 1.6 system, would be great).

I tested the /dev/null patch with 1.6 and it's ok. No warnings at all.

root@lisa:~# amportal stop



STOPPING ASTERISK
Asterisk Stopped

pnlarsson, I was hoping you could test the first patch I posted:

-  /usr/sbin/asterisk -rx "stop gracefully"
+  /usr/sbin/asterisk -rx "core stop gracefully" | grep -v "No such command"
+  /usr/sbin/asterisk -rx "stop gracefully" | grep -v -E "No such command|deprecated"

since it would allow some output if appropriate.

r5987 - checking the first one in.