Ticket #2641 (new Patches)

Opened 10 months ago

Last modified 6 months ago

FOP layers buttons when it runs out of positions

Reported by: skurylo Assigned to: asternic
Priority: minor Milestone: Cut Line
Component: Flash Operator Panel Version: SVN-HEAD
Keywords: Cc:
Confirmation: Unreviewed SVN Revision (if applicable):
Backend Engine: All Backend Engine Version:

Description

Right now when you run out of positions in the FOP, it starts from the beginning of the range, so you get two buttons in one positions. This is very confusing visually.

As well if I don't want trunks to show up and leave the position field blank, it puts them all at position 0.

This patch to trunk makes retrieve_op_conf_from_mysql.pl stop if it runs out of positions. Let me know if I should generate the patch in a different manner (I used svn diff)

Next I was going to work on ticket 2317. From there I was going to take a look at giving the option of having it auto calculate, as mentioned in the comments of 2317.

Thanks.

Attachments

retrieve_op_conf_from_mysql.pl.patch (1.7 kB) - added by skurylo on 01/23/08 08:51:20.

Change History

01/23/08 08:51:20 changed by skurylo

  • attachment retrieve_op_conf_from_mysql.pl.patch added.

02/11/08 04:51:11 changed by Nick_Lewis

I independently found and fixed the problem in the same way (though with a more c like syntax). It now works as expected when there are too may elements to display so I think the patch is a good one.

It may also be worth recording the previous button position and when there is an overflow displaying an overflow warning button over the top of the last real button e.g.

my $lastbtn=$btn; $btn=get_next_btn($extenpos,$btn); if ($btn eq 0) {

print EXTEN "[$dial]\nPosition=$lastbtn\nLabel=\"WARNING - OVERFLOW\"\n"; last;

}

However I have decided not to implement this on my installations

06/15/08 01:25:44 changed by lazytt

  • owner changed from lazytt to asternic.
Donate



Support
Download
Develop
Forums
News
Documentation
Paid Support
About

Paid Ads