Password for Voice Mail Box - Do not make it mandatory

try using use s option in a custom dialplan to bypass the voicemail password

Thanks.

But the GUI interface of FreePBX extension module insists on having a password. I could not leave the password field blank.

I use TrixBox. I know nothing about dialplan programming.

The 2.4.beta2 also insists on a password at the GUI for extension.

will review

This is a problem with the voicemail module. I was able to make the change in order to accept empty VM passwords in the FreePBX GUI:

admin/modules/voicemail/functions.inc.php line 349:

Change:

"frm_${display}_isVoiceMailEnabled() && !isInteger()"

To:

"frm_${display}_isVoiceMailEnabled() && !isEmpty() && !isInteger()"

- Darrin

Sorry - I'm using FreePBX 2.3, Core 2.3.1.4 and Voicemail 2.0.3.4 so the line number referenced above may be incorrect for a later version.

- Darrin

modules/voicemail/functions.inc.php diff to fix this bug

Attached a patch for the Voicemail module version 2.4.0.1 that fixes the problem in functions.inc.php.

I'm still not sure this is the best route to avoid having to enter you password to check VM. Currently you can enter any password in to the gui and use the s option to alleviate having to enter the password when you check your voicmeail. While you might need a line or two of dialplan to get that going, I dont think that the password field should be allowed to be left blank.

I disagree. This is a BUG. For the longest time one was able to leave the voicemail password field blank in the GUI. The interface needs to be flexible. Forcing the use of a password and then going into the dialplan and forcing the passwords to be ignored is not an appropriate solution. That approach does not allow for a mixture of the two modes.

A simple office with a small number of users who don't want passwords on their voicemail boxes my not have the savvy to update the dialplan in this way - look at the comments for an example of such a user.

This is a trivial fix, look a the patch (or indeed the thread above where the fix is described). If you want to add a "no voicemail password specified, are you sure" dialog box to the check, I could see that, but disallowing empty passwords is a bug, plain and simple.

It used to work and now it doesn't. That's a bug.

Replying to dgorski:

It used to work and now it doesn't. That's a bug.

No, this does not make something a bug. Something having worked may have been the bug. There are plenty of cases where javascripts were in place that were suppose to block things but had syntax errors that made them useless, or where there was no validation. So putting validation in place where there was not before is NOT a bug.

With that said, if you want to provide a patch that pulls up a confirmation box instead allowing the user to not put in a pass word but providing a warning, then feel free to submit it and we'll have a look at putting it in. But for now, allowing an empty password without any feedback IS a bug so until there is the above submitted it will be left as is.

Fair enough I suppose. I still liked it the other way, but I relent.

patch for modules/voicemail/functions.inc.php (2.4.0.1) with confirmation dialog

dgorski: Welcome aboard! r5929

Awesome. Thanks!

Your welcome. BTW, it seems like you quite capable. If your so inclined, we can always use another set of hands around here :)