Open Source Training Seminar FreePBX Paid Support

Ticket #1729 (closed Feature Requests: duplicate)

Opened 2 years ago

Last modified 1 year ago

Enable Non-Latin1 text for name fields

Reported by: lazytt Assigned to: diego_iastrubni
Priority: major Milestone: 2.2
Component: Core Version: 2.2
Keywords: hebrew unicode Cc:
Confirmation: SVN Revision (if applicable):
Backend Engine: All Backend Engine Version:

Description

Most fields generate an error when I try to save them with hebrew text. For example:
--the phone book name field will return "please enter a valid name"
--the extensions name field will return "Please enter a valid callID"

i don't believe that the db's cant support the characters, the only limitation should be the end user system. I presume the gui is checking for certain encoding and thus limiting us to English characters only. I would like to have the option of saving names in other characters too.

Attachments

exten.JPG (35.2 kB) - added by lazytt on 02/04/07 03:14:28.

Change History

01/31/07 07:03:43 changed by lazytt

ok. so it seems this would be the step to remove the restircion on the gui

/var/www/html/admin/common/script.js.php
line
-657 {   return ( ((c >= "a") && (c <= "z")) || ((c >= "A") && (c <= "Z")) || (c == " ") || (c == "&") || (c == "'") || (c == "(") || (c == ")") || (c == "-") || (c == "/"))
/var/www/html/admin/common/script.js.php
line
+657 {   return ( ((c >= "a") && (c <= "z")) || ((c >= "A") && (c <= "Z")) || ((c >= "א") && (c <= "ת")) || (c == " ") || (c == "&") || (c == "'") || (c == "(") || (c == ")") || (c == "-") || (c == "/"))

However the field gets written to the sql in giberish. Is the gui screwing it up? My browsers (firefox) encoding? Im using utf-8 does Linux have a problem with Hebrew?

02/04/07 03:14:28 changed by lazytt

  • attachment exten.JPG added.

02/04/07 03:16:41 changed by lazytt

Update: Thanks to cuco for this. The sql is actualy saving fine. The problem is mainly when the gui puts the extension name in the caller id field. A picture is worth a thousand words. have a look!

02/07/07 00:19:35 changed by diego_iastrubni

  • keywords changed from hebrew to hebrew unicode.
  • owner set to diego_iastrubni.
  • summary changed from Enable Hebrew text for name fields to Enable Non-Latin1 text for name fields.

The checking for non Latin1 chars was done to avoid SQL injections. It's not a high priority to have UTF-8 support in field names, since anyway most of the devices will not be able to show BIDI or CJK.

I will find some time to fix the display issues, but I will leave the JS test, which means you cannot enter then from the WEB GUI. If those names are in the SVN, cool, freePBX will display them. But you will not be able to enter them.

(unless someone shows a better JS test for those strings)

I also changed the name of this bug from: "Enable Hebrew text for name fields" to: "Enable Non-Latin1 text for name fields"

02/23/07 14:27:13 changed by andre_ruiz

I am pro this feature request, but just for documentation, will leave my experience with that, so if that happens again, people will have some clue about it.

I saw a really strange thing happening with asterisk when you use non-standard chars (anything not just letters and digits and spaces, specially letter with accents) in the extension name. It seems very harmless, but maybe the problem was because that names end up in the caller ID of the extension while making a call and asterisk goes crazy.

We spent a few months searching for the cause in an asterisk population of about 200 servers, and after we casually located and isolated it, it became somewhat clear (even not happening 100% of the time). The call will last for about 5 to 10 seconds and will drop, no explanation. (we had modified freepbx to allow accents).

Here in Brazil it is very common to have accents in letters in the persons names, so we had plenty and the problem was epidemic. After banning them, no more cases happened. This was with asterisk 1.0 (mainly) and asterisk 1.2 (a few).

05/25/07 02:46:50 changed by lazytt

  • status changed from new to closed.
  • resolution set to duplicate.

Dup of #1955

Donate



Support
Download
Develop
Forums
News
Documentation
Paid Support
About

Paid Ads