Patch to fix #1487 Queue number 0

what is this doing in newinstall.sql?!?

--
-- Table structure for table `queues`
--

DROP TABLE IF EXISTS `queues`;
CREATE TABLE `queues` (
  `id` bigint(11) NOT NULL default '-1',
  `keyword` varchar(20) NOT NULL default '',
  `data` varchar(150) NOT NULL default '',
  `flags` int(1) NOT NULL default '0',
  PRIMARY KEY  (`id`,`keyword`,`data`)
) ENGINE=MyISAM;

actually not the only module which doesn't handle its own table. probably still left from pre-module days. but it needs to be fixed as above.

ALTER TABLE `queues` CHANGE `id` `id` VARCHAR( 45 ) NOT NULL DEFAULT '-1'

and i'm not sure where to put it. so i'm leaving that up to you.

put a hold on this... I found another bug.

ok, the above diff should be replaced with this one. one got by me the first time.

Index: page.queues.php
===================================================================
--- page.queues.php     (revision 3557)
+++ page.queues.php     (working copy)
@@ -151,16 +151,16 @@
        <h2><?php echo _("Add Queue"); ?></h2>
 <?php } ?>

-<?php          if ($extdisplay){ ?>
+<?php          if ($extdisplay != ''){ ?>
        <p><?php echo $delButton ?></p>
 <?php          } ?>
        <form autocomplete="off" name="editQ" action="<?php $_SERVER['PHP_SELF'] ?>" method="post">
        <input type="hidden" name="display" value="<?php echo $dispnum?>">
-       <input type="hidden" name="action" value="<?php echo ($extdisplay ? 'edit' : 'add') ?>">
+       <input type="hidden" name="action" value="<?php echo (($extdisplay != '') ? 'edit' : 'add') ?>">
        <table>
        <tr><td colspan="2"><h5><?php echo ($extdisplay ? _("Edit Queue") : _("Add Queue")) ?><hr></h5></td></tr>
        <tr>
-<?php          if ($extdisplay){ ?>
+<?php          if ($extdisplay != ''){ ?>
                <input type="hidden" name="account" value="<?php echo $extdisplay; ?>">
 <?php          } else { ?>
                <td><a href="#" class="info"><?php echo _("queue number:")?><span><?php echo _("Use this number to dial into the queue, or transfer callers to this number to put them into the queue.<br><br>Agents will dial this queue number plus * to log onto the queue, and this queue number plus ** to log out of the queue.<br><br>For example, if the queue number is 123:<br><br><b>123* = log in<br>123** = log out</b>")?></span></a></td>
@@ -535,7 +535,7 @@
                 }
                 whichitem++;
         }
-
+/*
         var gotoType = theForm.elements[ "goto0" ].value;
         if (gotoType == 'custom') {
                 var gotoVal = theForm.elements[ "custom0"].value;
@@ -544,12 +544,13 @@
                                                <?php echo "alert('"._("Custom Goto contexts must contain the string \"custom\".  ie: custom-app,s,1")."')"?>;
                 }
         }
-
+*/
         $account = theForm.account.value;
         if ($account == "") {
                 <?php echo "alert('"._("Queue Number must not be blank")."')"?>;
                 bad="true";
         }
+/*
        else if ($account == "0") {
                 <?php echo "alert('"._("Queue Number can not be 0")."')"?>;
                 bad="true";
@@ -558,7 +559,7 @@
                 <?php echo "alert('"._("Queue numbers with more than one digit cannot begin with 0")."')"?>;
                 bad="true";
         }
-
+*/
         if ($queuename == "") {
                 <?php echo "alert('"._("Queue name must not be blank")."')"?>;
                 bad="true";

also the retrieve script has to be changed.

Index: retrieve_queues_conf_from_mysql.pl
===================================================================
--- retrieve_queues_conf_from_mysql.pl  (revision 3557)
+++ retrieve_queues_conf_from_mysql.pl  (working copy)
@@ -57,7 +57,7 @@
        $dbh = DBI->connect("dbi:SQLite2:dbname=$db_file","","");
 }

-$statement = "SELECT keyword,data from $table_name where id=0 and keyword <> 'account'";
+$statement = "SELECT keyword,data from $table_name where id='-1' and keyword <> 'account'";
 my $result = $dbh->selectall_arrayref($statement);
 unless ($result) {
   # check for errors after every single database call
@@ -99,7 +99,7 @@
        my $account = @{ $row }[0];
        my $id = @{ $row }[1];
        print EXTEN "[$account]\n";
-       $statement = "SELECT keyword,data from $table_name where id=$id and keyword <> 'account' order by flags";
+       $statement = "SELECT keyword,data from $table_name where id='$id' and keyword <> 'account' order by flags";
        my $result = $dbh->selectall_arrayref($statement);
        unless ($result) {
                # check for errors after every single database call

and just to have everything in one post, here is the sql which must be run.

ALTER TABLE `queues` CHANGE `id` `id` VARCHAR( 45 ) NOT NULL DEFAULT '-1'

partially fixed in 2.2 branch in r3744

changing to a bug to review and apply in 2.3 as necessary

r4631