Putting format <1234> within display name breaks internal callerid

More details and discussion with groogs:

Scenario you may want to do this:

user is part of a team (e.g. tech support) and WANTS their internal outbound callerid spoofed to be a support ringgroup or queue.

Questions:

would this break other stuff (other than trivial things like direct dial voicemail not working)?

ISSUE REMAINS:

In either case, the following is a bug and SHOULD be handled properly depending on what we decided is correct behavior:

Extension: 200 Display Name: Help Desk <611>

Results in sip_additional.conf (and in database):

Help Desk <611> <200>

This is an undefined callerid format. It is currently handled gracefully by asterisk by using the <611> as the CALLERID(number) but that may not always be the case. If we choose to allow this, then the <200> should go away. If not, we should block it with the javascript as well as cleanse it in the code if it gets through.

If we choose to allow it, we should still pop up a warning ('are you sure you want this?') and in either case, we should modify the fly over help to be more explicit since right now it is a bit ambiguous.

this also breaks recordings made via SIP extension. see bug 1303

OK - I'm moving this to 2.2 and marking it as crash as it is the cause of modules like Recordings crashing. Putting a Display Name with <XXX> is breaking features like music on hold downloads and probably other stuff. This needs to be fixed in 2.1 and 2.2. We simply can not allow the <> or alternatively, we need to remove them or replace them with something that won't make it look like a caller id. (maybe simple replace < with ( and > with ) in the backend and modify the java script to tell them they can't put in <> as well as modify the fly over help which is misleading as it tells them this is the callerid which many people think should have the <>

fixed in r3064 and r3065. If you put in a number like <xxx> it will be silently replaced with (xxx) in the display name so cid is not broken. (should probably add a javascript to not allow the other format if someone feels like it).

Milestone 2.2 deleted