Ticket #1142 (closed Bugs: fixed)

Opened 2 years ago

Last modified 2 years ago

ALERT-INFO Cutting Off Text

Reported by: mikes2277 Assigned to:
Priority: minor Milestone: 2.2
Component: Follow Me Version: SVN-HEAD
Keywords: ALERT INFO grandstream GXP2000 GXP-2000 Cc:
Confirmation: SVN Revision (if applicable):
Backend Engine: All Backend Engine Version:

Description (Last modified by p_lindheimer)

When setting "Alert Info" in the find me module it cuts of anything from a ; on. It may also do this on other "Altert Info" fields in other modules but I have not tried it.

According to Grandstream's FAQ for the GXP-2000 http://www.grandstream.com/FAQ/GXPEnterprisePhone_b.htm#X13 you have to format your Alert-Info in the fllowing mannor:

Alert-Info: <http://www.example.com>;info=priority

So I placed the full <http://www.example.com>;info=priority into the "Alert Info" field on the find me module's page. The result however is that it cuts off from starting at the ";". Apparently without the full <XXX>;info=something the distinctive ringing on the GXP-2000 will not work. FYI the URL has no relevance and is not used but it won't work unless you put it in.

I am getting the following SIP message sent from Asterisk to my phone. As you can see the Alert-Info is missing the ";info=priority". 

U 198.8 -> 74.135.81.96:50000
INVITE sip:5076@192.168.1.2:5060 SIP/2.0.
Via: SIP/2.0/UDP 198.8;branch=z9hG4bK2d367091;rport.
From: "" <sip:@198.88.216.105>;tag=as41b842ad.
To: <sip:5076@192.168.1.2:5060>.
Contact: <sip:@198.88.216.105>.
Call-ID: 2e11d1a878ade5d73af13dba10cda2fb@198.88.216.105.
CSeq: 102 INVITE.
User-Agent: Asterisk PBX.
Max-Forwards: 70.
Date: Sun, 24 Sep 2006 18:00:13 GMT.
Alert-Info: <http://www.example.com>.
Allow: INVITE, ACK, CANCEL, OPTIONS, BYE, REFER, SUBSCRIBE, NOTIFY.
Content-Type: application/sdp.
Content-Length: 267.
.
v=0.
o=root 32661 32661 IN IP4 198.88.216.105.
s=session.
c=IN IP4 198.88.216.105.
t=0 0.
m=audio 19186 RTP/AVP 18 0 101.
a=rtpmap:18 G729/8000.
a=fmtp:18 annexb=no.
a=rtpmap:0 PCMU/8000.
a=rtpmap:101 telephone-event/8000.
a=fmtp:101 0-16.
a=silenceSupp:off - - - -.

Anyway, after looking at extensions_additional.conf I found:

exten => 5075,n,Set(_ALERT_INFO=<http://www.example.com>;info=priority)

Hmmm, it appears that its being written correctly to the file... or is it... It seems that no where in Digium's documentation nor anywhere in the http://www.voip-info.org site is there anything stating that a ";" is a "special" charicter. It seems that it is and has to be escaped by a "\". When I manualy change the line to:

exten => 5075,n,Set(_ALERT_INFO=<http://www.example.com>\;info=priority)

Everything works properly and distinctive ringing behaves as expected. Can you please modify the code to add the "\" before a ";" in the Alert Info fiedls? Thanks!

Change History

09/24/06 11:55:41 changed by mikes2277

One more thing I forgot to mention. I tried putting the "\" on the follow me module page but it seems that FreePBX or PHP is stripping out the "\" before it gets written to the file so there is no way to make this work without having to manually edit the extensions_additional.conf every time you save your config until the code gets fixed.

Thanks!

09/24/06 12:52:16 changed by webrainstorm

You're right, Asterisk needs to have semicolons escaped as they are a special separator character in SIP headers.

See (http://www.ietf.org/rfc/rfc3261.txt)

09/24/06 12:53:26 changed by webrainstorm

  • status changed from new to closed.
  • resolution set to fixed.

Fixed in r2595 - Thanks

09/24/06 14:34:44 changed by mikes2277

  • status changed from closed to reopened.
  • resolution deleted.

I just updated to r2598 and it is still not escaping the alert info:

exten => 5075,n,Set(_ALERT_INFO=<http://www.example.com>;info=priority)

09/24/06 14:53:25 changed by webrainstorm

It does, did you apply changes at least once after upgrading ?

09/24/06 15:13:08 changed by mikes2277

Nope. I did a "svn update", "install_amp" and then went to the admin page and clicked on the red bar at the top and its still missing the "\" in the extensions_additional.conf. I then erased the Alert Info, saved and put it back in and saved again but my extensions_additional.conf still shows without the "\". If you can tell me what file and about what line in what PHP file is writing it out I can debug it for you and let you know what I see on my server.

Thanks!

09/24/06 15:48:31 changed by webrainstorm

here it is: http://freepbx.org/trac/changeset/2595. str_replace does the job, is this the version you had ?

tnx

09/24/06 16:03:19 changed by mikes2277

Mine still shows the old code. When I'm doing a svn update its on the main code. I don't think the plugins get updated from that. To update the plugins I always go to the admin page under module admin and look for anything to show up orange. At this time there are no updates available there. I take it you have to checkout the modules seperately and the module admin in the core is not always getting the latest svn in the development release? Should I just checkout the code via the svn and then just do a "cp -R /usr/src/freepbx-module/* /var/www/html/modules/"? Is that safe (or the proper way at least) on a live system that is already running SVN core code? I didn't see any sort of install/update script to do this.

Thanks!

09/24/06 20:32:44 changed by p_lindheimer

  • status changed from reopened to closed.
  • resolution set to fixed.
  • description changed.

looks to me like the bug is fixed. Webrainstorm just hasn't published the new modules which is what will make them show up in the online repository. He or someone else has to do that. (I'd do it now but am running off so will do it later/tomorrow if it doesn't get done. Hop on the IRC if you are waiting for it, or you can just manually grab the specific fixed files and install them by hand until the update gets published).

p

09/24/06 23:22:32 changed by webrainstorm

Oh, I thought he was running modules form a SVN checkout.

Modules are published now, you can update them.

E.

01/08/07 11:46:44 changed by

  • milestone deleted.

Milestone 2.2 deleted

01/08/07 13:17:05 changed by vgster

  • milestone set to 2.2.
Donate



Support
Download
Develop
Forums
News
Documentation
Paid Support
About

Paid Ads